Skip to content

Conversation

Manisha1679
Copy link
Contributor

Description
When the Files app is in RTL mode, the WebView content in Release Notes was mirrored. This PR forces the WebView to display content Left-to-Right.

Resolved / Related Issues

Steps used to test these changes

  1. Opened Files.
  2. Changed app language to an RTL language (e.g., Arabic or Hebrew) from Settings → Preferences → Language.
  3. Navigated to Release Notes page.
  4. Verified that the sidebar, toolbar, and other app UI correctly display in RTL.
  5. Verified that the Release Notes WebView content stays in LTR (not mirrored).
  6. Tested switching back to English (LTR) to confirm that Release Notes still display correctly.
  7. Clicked a few links inside Release Notes to ensure normal behavior (open in browser).

@yaira2 yaira2 changed the title Fix : mirrored WebView content in RTL mode (#17615) Fix: Fixed issue where release notes was mirrored in RTL Sep 16, 2025
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Sep 16, 2025
@yaira2
Copy link
Member

yaira2 commented Sep 16, 2025

@Manisha1679 thank you for the PR. Does it work to set the flow direction in the ReleaseNotesPage xaml file?

@Manisha1679
Copy link
Contributor Author

Are you asking me to make changes in ReleaseNotesPage.xaml?

@yaira2
Copy link
Member

yaira2 commented Sep 17, 2025

Are you asking me to make changes in ReleaseNotesPage.xaml?

Correct. If possible, it would be preferable to set the FlowDirection in the xaml instead of the code behind.

@Manisha1679
Copy link
Contributor Author

Yes, It is possible. I will do it at the earliest,maybe by tomorrow evening.

@Manisha1679
Copy link
Contributor Author

Thanks for the suggestion! 🙌
I’ve updated the PR to set FlowDirection="LeftToRight" directly in ReleaseNotesPage.xaml instead of code-behind.
This keeps the fix cleaner and resolves the merge conflict as well.

@Manisha1679
Copy link
Contributor Author

Their is a small indentation issue. I tried to fix it ,now also it's showing conflicts but both branches are literally the same as I can see.

Signed-off-by: Yair <39923744+yaira2@users.noreply.github.com>
yaira2
yaira2 previously approved these changes Sep 18, 2025
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Sep 18, 2025
@yaira2
Copy link
Member

yaira2 commented Sep 18, 2025

@Manisha1679 I fixed the spacing issue.

@yaira2
Copy link
Member

yaira2 commented Sep 18, 2025

/format

@Manisha1679
Copy link
Contributor Author

@Manisha1679 I fixed the spacing issue.

Thank you so much

@files-community-bot
Copy link
Contributor

✅ Successfully formatted XAML files.

@yaira2 yaira2 merged commit 7c2e9c8 into files-community:main Sep 18, 2025
@Manisha1679
Copy link
Contributor Author

Actually this is my first contribution so I just want to know if I am eligible to be in the the contributors list for this issue? And did I successfully complete my first contribution?

@yaira2
Copy link
Member

yaira2 commented Sep 18, 2025

@Manisha1679 you'll automatically show up in the list of contributors 🎉

And did I successfully complete my first contribution?

You certainly did, thank you for contributing to Files!

@Manisha1679
Copy link
Contributor Author

Thank you so much.

@Manisha1679
Copy link
Contributor Author

Manisha1679 commented Sep 18, 2025

Sorry to interrupt but I can't find my name in the contributors list. I am just very excited to see it.

@yaira2
Copy link
Member

yaira2 commented Sep 18, 2025

@Manisha1679
Copy link
Contributor Author

I am not there on the list

@Manisha1679
Copy link
Contributor Author

Hi, I still can't see my name on the contributors list. Actually I needed it for a purpose.

@yaira2
Copy link
Member

yaira2 commented Sep 28, 2025

It could be GitHub hasn't updated the list yet. In any event, you can find your contribution in the commit history.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: RTL Files mirrors anything in Webview
2 participants