-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Fix: Fixed issue where release notes was mirrored in RTL #17622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixed issue where release notes was mirrored in RTL #17622
Conversation
@Manisha1679 thank you for the PR. Does it work to set the flow direction in the |
Are you asking me to make changes in ReleaseNotesPage.xaml? |
Correct. If possible, it would be preferable to set the FlowDirection in the xaml instead of the code behind. |
Yes, It is possible. I will do it at the earliest,maybe by tomorrow evening. |
Thanks for the suggestion! 🙌 |
Their is a small indentation issue. I tried to fix it ,now also it's showing conflicts but both branches are literally the same as I can see. |
Signed-off-by: Yair <39923744+yaira2@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Manisha1679 I fixed the spacing issue. |
/format |
Thank you so much |
✅ Successfully formatted XAML files. |
Actually this is my first contribution so I just want to know if I am eligible to be in the the contributors list for this issue? And did I successfully complete my first contribution? |
@Manisha1679 you'll automatically show up in the list of contributors 🎉
You certainly did, thank you for contributing to Files! |
Thank you so much. |
Sorry to interrupt but I can't find my name in the contributors list. I am just very excited to see it. |
I am not there on the list |
Hi, I still can't see my name on the contributors list. Actually I needed it for a purpose. |
Description
When the Files app is in RTL mode, the WebView content in Release Notes was mirrored. This PR forces the WebView to display content Left-to-Right.
Resolved / Related Issues
Steps used to test these changes